OBM
  1. OBM
  2. OBMFULL-5269

Email of an event updated should not propose Accept/Decline in EarlyBird 24

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Normal Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: mozilla-connector
    • Labels:
    • Environment:

      EarlyBird 24.0a2(2013-07-18)
      Lightning 2.6a2
      OBM connector 4.0.0.0+git2013-07-15_13_12efc81

    • Similar Issues:
      Show 10 results 
    • Rank:
      5397

      Description

      Pre-conditions

      Assistant has read and write access to Boss calendar

      Reproduction steps

      1. Using TBird/Lightning, Boss creates a new event "MEETING" tomorow at 10 and adds Assistant in the attendee list
      2. Boss choses to notify Assistant, then he synchronizes
      3. Boss moves the event to the day after tomorrow at 10, then notifies and synchronizes
      4. Boss moves the event again to next week at 14, then notifies and synchronizes
      5. Asssistant synchronizes with TBird obm connector

      Current behaviour

      1. assistant has several email for the event "MEETING". One for the new event tomorrow at 10, then an update for the day after tomorrow, then another update for next week at 14. Buttons "Accept/Decline" are displayed in all emails NOK

      Expected behaviour

      1. assistant has several email for the event "MEETING". One for the new event tomorrow at 10, then an update for the day after tomorrow, then another update for next week at 14. Buttons "Accept/Decline" are only displayed in the last update email. Others have "open" button OK

      Additional informations

      See screenshot, at the top earlyBird 24, and at the bottom, Thunderbird 17. The same email displays "open" with TB17 and "Accept/Decline" with TB24.

        Activity

        Hide
        Philipp Kewisch (Inactive) added a comment -

        This is actually a "feature", we might need to discuss. It was introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=827279.

        As the assistant has not replied to the event by setting a participation status (its still NEEDS-ACTION), the accept/decline buttons show up. As soon as the assistant has changed the status, it should be ok.

        Maybe these steps will uncover a potential bug. Please also test in tb17 to make sure this wasn't already broken:

        1. Using TBird/Lightning, Boss creates a new event "MEETING" tomorow at 10 and adds Assistant in the attendee list
        2. Boss choses to notify Assistant, then he synchronizes
        3. Boss moves the event to the day after tomorrow at 10, then notifies and synchronizes
        4. Assistant synchronizes, accepts event
        5. Boss moves the event again to next week at 14, then notifies and synchronizes
        6. Asssistant synchronizes

        Expected behavior: The assistant should be presented with accept/decline buttons because the time of the event has changed.

        Show
        Philipp Kewisch (Inactive) added a comment - This is actually a "feature", we might need to discuss. It was introduced in https://bugzilla.mozilla.org/show_bug.cgi?id=827279 . As the assistant has not replied to the event by setting a participation status (its still NEEDS-ACTION), the accept/decline buttons show up. As soon as the assistant has changed the status, it should be ok. Maybe these steps will uncover a potential bug. Please also test in tb17 to make sure this wasn't already broken: Using TBird/Lightning, Boss creates a new event "MEETING" tomorow at 10 and adds Assistant in the attendee list Boss choses to notify Assistant, then he synchronizes Boss moves the event to the day after tomorrow at 10, then notifies and synchronizes Assistant synchronizes, accepts event Boss moves the event again to next week at 14, then notifies and synchronizes Asssistant synchronizes Expected behavior : The assistant should be presented with accept/decline buttons because the time of the event has changed.
        Hide
        Stephane COLSON added a comment -

        Well...I'm not sure this is a good idea. In the example, I have 3 emails:
        1. one for the creation of the event tomorrow at 10
        2. one for the modification of the event the day after tomorrow
        3. one for the modification of the event next week at 14

        Buttons Accept/Decline are displayed in all the 3 emails.

        If I open the first email, I see the message "boss has invited you to Event...tomorrow at 10:00 AM", if I click on accept, I think that I accept a meeting at 10:00 AM tomorrow. But in fact by doing this I'm adding the event next week at 14. This is misleading.

        Show
        Stephane COLSON added a comment - Well...I'm not sure this is a good idea. In the example, I have 3 emails: 1. one for the creation of the event tomorrow at 10 2. one for the modification of the event the day after tomorrow 3. one for the modification of the event next week at 14 Buttons Accept/Decline are displayed in all the 3 emails. If I open the first email, I see the message "boss has invited you to Event...tomorrow at 10:00 AM", if I click on accept, I think that I accept a meeting at 10:00 AM tomorrow. But in fact by doing this I'm adding the event next week at 14. This is misleading.
        Hide
        Stephane COLSON added a comment -

        Decide what to do...

        Show
        Stephane COLSON added a comment - Decide what to do...
        Hide
        Michael Bailly added a comment -

        This seems to be a bug. In step 6. of the original JIRA desc, the lightning event should have the latest sequence number. The two first emais having an inferior sequence number, lightning should not present the accept/decline buttons to the user.

        Show
        Michael Bailly added a comment - This seems to be a bug. In step 6. of the original JIRA desc, the lightning event should have the latest sequence number. The two first emais having an inferior sequence number, lightning should not present the accept/decline buttons to the user.
        Hide
        Philipp Kewisch (Inactive) added a comment -

        Ok, I have a patch that fixes this issue in a better way, see reviews. I understand that its confusing to have all emails show the Accept/Decline buttons.

        For testing, I have gone through the initial steps mentioned in the description. I have also tested the steps in OBMFULL-4324, which is not regressed.

        Please use the initial reproducion steps for QA, also other invitation features may be affected.

        Show
        Philipp Kewisch (Inactive) added a comment - Ok, I have a patch that fixes this issue in a better way, see reviews. I understand that its confusing to have all emails show the Accept/Decline buttons. For testing, I have gone through the initial steps mentioned in the description. I have also tested the steps in OBMFULL-4324 , which is not regressed. Please use the initial reproducion steps for QA, also other invitation features may be affected.
        Hide
        Jenkins Continuous Integration Server added a comment -

        Integrated in build-lightning-connector-next-tb24 #16
        OBMFULL-5269 - Email of an event updated should not propose Accept/Decline in EarlyBird 24 (Revision eeaa103191e848bd458b7df62564cc93a29e4abe)

        Result = SUCCESS
        aduprat :
        Files :

        • src/components/calOBMCalendar.js
        • src/modules/calItipUtilsOverlay.jsm
        • src/components/obm-sync-rest/obmRCalendarSync.js
        • src/modules/UtilsOBM.jsm
        Show
        Jenkins Continuous Integration Server added a comment - Integrated in build-lightning-connector-next-tb24 #16 OBMFULL-5269 - Email of an event updated should not propose Accept/Decline in EarlyBird 24 (Revision eeaa103191e848bd458b7df62564cc93a29e4abe) Result = SUCCESS aduprat : Files : src/components/calOBMCalendar.js src/modules/calItipUtilsOverlay.jsm src/components/obm-sync-rest/obmRCalendarSync.js src/modules/UtilsOBM.jsm
        Hide
        Stephane COLSON added a comment -

        OK with TB24 (finale release) + OBM Connector 4.0.0.0+git2013-10-01_16_eeaa103

        Show
        Stephane COLSON added a comment - OK with TB24 (finale release) + OBM Connector 4.0.0.0+git2013-10-01_16_eeaa103

          People

          • Assignee:
            Philipp EXT_KEWISCH
            Reporter:
            Stephane COLSON
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: