OBM
  1. OBM
  2. OBMFULL-6066

Always close the httpclient when the scenario is done

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Normal Normal
    • Resolution: Fixed
    • Affects Version/s: 2.5.7
    • Fix Version/s: 2.5.8
    • Component/s: spushnik
    • Labels:
      None
    • Story Points:
      1
    • Similar Issues:
      Show 10 results 
    • Rank:
      6338
    • Sprint:
      Lyon Sprint 26/08/2014

      Description

      Current behavior:
      Always close the httpclient when the scenario is done.
      Spushnik never close its http client why should make the file descriptor growing and this service not stable.

      Expected behavior:
      No more file-descriptor leak by using spushnik

        Issue Links

          Activity

          Hide
          Thomas HILAIRE added a comment - - edited

          QA:
          Note that I didn't see the problem with this method, may be that my OS was releasing file descriptor in a smarter way than in production context..
          edit: along the time the amount of CLOSE_WAIT socket increase

          To reproduce you have to script spushnik requests, in /tmp/spushnik_request.sh :

          curl -s http://10.69.1.20:8082/spushnik/foldersync?serviceUrl=https://localhost/Microsoft-Server-ActiveSync -v -H "Accept: application/json" -H "Content-type: application/json" -X POST -d '{"loginAtDomain":"usera@obm21.lyn.lng","password":"usera"}'
          

          ..then in a loop:

          for i in {1..10000}; do ~/tmp/spushnik_request.sh && sleep 1; done

          .. then the file descriptor count of jetty should be growing.

          Impacts: Just verify that spushnik continue to do its job as expected

          Show
          Thomas HILAIRE added a comment - - edited QA : Note that I didn't see the problem with this method, may be that my OS was releasing file descriptor in a smarter way than in production context.. edit: along the time the amount of CLOSE_WAIT socket increase To reproduce you have to script spushnik requests, in /tmp/spushnik_request.sh : curl -s http: //10.69.1.20:8082/spushnik/foldersync?serviceUrl=https://localhost/Microsoft-Server-ActiveSync -v -H "Accept: application/json" -H "Content-type: application/json" -X POST -d '{ "loginAtDomain" : "usera@obm21.lyn.lng" , "password" : "usera" }' ..then in a loop: for i in {1..10000}; do ~/tmp/spushnik_request.sh && sleep 1; done .. then the file descriptor count of jetty should be growing. Impacts : Just verify that spushnik continue to do its job as expected
          Hide
          Jenkins Continuous Integration Server added a comment -

          SUCCESS: Integrated in poll-qa-25 326-1ab8d93df26b4003cca23a74864a32563e089728
          OBMFULL-6066 Always close the httpclient when the scenario is done (jkornobis: fd1854e4ba3e55182799a4222d2fb5febd207b24)

          • java/sync/opush/spushnik/src/test/java/org/obm/push/spushnik/resources/ScenarioTest.java
          • java/sync/opush/spushnik/src/main/java/org/obm/push/spushnik/resources/Scenario.java
          • java/sync/opush/client/src/main/java/org/obm/sync/push/client/OPClient.java
          Show
          Jenkins Continuous Integration Server added a comment - SUCCESS: Integrated in poll-qa-25 326-1ab8d93df26b4003cca23a74864a32563e089728 OBMFULL-6066 Always close the httpclient when the scenario is done (jkornobis: fd1854e4ba3e55182799a4222d2fb5febd207b24 ) java/sync/opush/spushnik/src/test/java/org/obm/push/spushnik/resources/ScenarioTest.java java/sync/opush/spushnik/src/main/java/org/obm/push/spushnik/resources/Scenario.java java/sync/opush/client/src/main/java/org/obm/sync/push/client/OPClient.java
          Hide
          Matthieu EXT_BAECHLER added a comment -

          Not reproduced with 2.5.7, maybe you hit another problem after some time.

          Show
          Matthieu EXT_BAECHLER added a comment - Not reproduced with 2.5.7, maybe you hit another problem after some time.

            People

            • Assignee:
              Thomas HILAIRE
              Reporter:
              Thomas HILAIRE
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile