OBM
  1. OBM
  2. OBMFULL-6428

CLONE 2.5 - T#11012 T#11601 Cannot parse email containing an attachment with multiple key-value name

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Normal Normal
    • Resolution: Fixed
    • Affects Version/s: 2.5.10
    • Fix Version/s: 2.5.11
    • Component/s: None
    • Labels:
      None
    • Similar Issues:
      Show 9 results 
    • Rank:
      6891

      Description

      Pre-conditions

      OBM on Debian (tested with wheezy and Cyrus v2.4.16-Debian-2.4.16-4+deb7u2).
      Cannot be reproduced with OBM on CentOS as I can't import the email, it complains by saying : A005 NO Message contains invalid header

      Have an email containing an attachment with multiple key-value entry for its name like :

      
      --Boundary_(ID_qICUBLUGegfH+OcwQRmMAw)
      Content-id: <3b1a53bf-8776-4156-0178-cb5d38fdcd72@icloud.com>
      Content-type: application/octet-stream; name*1*=utf-8''%42%41%20%2B%20%51%53%20%5F%20%41%73; name*2*=%73%75%72%61%6E%63%65%20%44%C3%A9%63; name*3*=%C3%A8%73%20%70%6F%75%72%20%49%6E%76; name*4*=%65%73%74%69%73%73%65%75%72%2E%70%64%66
      Content-transfer-encoding: BASE64
      Content-disposition: attachment; filename*1*=utf-8''%42%41%20%2B%20%51%53%20%5F%20%41%73; filename*2*=%73%75%72%61%6E%63%65%20%44%C3%A9%63; filename*3*=%C3%A8%73%20%70%6F%75%72%20%49%6E%76; filename*4*=%65%73%74%69%73%73%65%75%72%2E%70%64%66
      
      JVBERi0xLjUNJeLjz9MNCjEwODUgMCBvYmoNPDwvTGluZWFyaXplZCAxL0wg
      MjU4MjY1L08gMTA4Ny9FIDczMTM4L04gNy9UIDIzNjQ0OC9IIFsgMTQ5NiA1
      NDldPj4NZW5kb2JqDSAgICAgICAgICAgIA14cmVmDTEwODUgNjANMDAwMDAw
      MDAxNiAwMDAwMCBuDQowMDAwMDAyMjQ5IDAwMDAwIG4NCjAwMDAwMDI0MTUg
      MDAwMDAgbg0KMDAwMDAwMzAxNSAwMDAwMCBuDQowMDAwMDAzNDk5IDAwMDAw
      

      Reproduction steps

      1. As usera, I have such email in my INBOX
      2. As usera, I try to synchronize my INBOX

      Current behavior

      1. I can't synchronize my INBOX

      Expected behavior

      1. I can synchronize my INBOX and receive the mail
      1. 33502.eml
        1.86 MB
        David Dolcimascolo
      2. asterisk-multi.eml
        1.86 MB
        Thomas HILAIRE

        Issue Links

          Activity

          Hide
          Jenkins Continuous Integration Server added a comment -

          SUCCESS: Integrated in poll-master-2.5 #404
          OBMFULL-6428 Decoding fallback when no charset found (thilaire: 249e580d8a317e1a53d6507c55383c6d1cb2502e)

          • java/sync/opush/linagora-mail/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java
          • java/sync/opush/linagora-mail/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java
            OBMFULL-6428 Removed unused key rewriter (thilaire: 995eafd9941ca152b82b7bd9afe1be53f7146746)
          • java/sync/opush/linagora-mail/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java
            OBMFULL-6428 BodyParam can now be grouped (thilaire: 9ddf166d57a228f6efcbff2ce8eb3cbba62360b4)
          • java/sync/opush/mail-backend-interfaces/src/main/java/org/obm/push/mail/mime/BodyParam.java
          • java/sync/opush/linagora-mail/src/test/java/org/obm/push/minig/imap/mime/impl/BodyParamParserTest.java
          • java/sync/opush/linagora-mail/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java
          • java/sync/opush/mail-backend-interfaces/src/main/java/org/obm/push/mail/mime/BodyParams.java
          • java/sync/opush/linagora-mail/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java
          • java/sync/opush/mail-backend-interfaces/src/test/java/org/obm/push/mail/bean/BeansTest.java
          Show
          Jenkins Continuous Integration Server added a comment - SUCCESS: Integrated in poll-master-2.5 #404 OBMFULL-6428 Decoding fallback when no charset found (thilaire: 249e580d8a317e1a53d6507c55383c6d1cb2502e ) java/sync/opush/linagora-mail/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java java/sync/opush/linagora-mail/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java OBMFULL-6428 Removed unused key rewriter (thilaire: 995eafd9941ca152b82b7bd9afe1be53f7146746 ) java/sync/opush/linagora-mail/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java OBMFULL-6428 BodyParam can now be grouped (thilaire: 9ddf166d57a228f6efcbff2ce8eb3cbba62360b4 ) java/sync/opush/mail-backend-interfaces/src/main/java/org/obm/push/mail/mime/BodyParam.java java/sync/opush/linagora-mail/src/test/java/org/obm/push/minig/imap/mime/impl/BodyParamParserTest.java java/sync/opush/linagora-mail/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java java/sync/opush/mail-backend-interfaces/src/main/java/org/obm/push/mail/mime/BodyParams.java java/sync/opush/linagora-mail/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java java/sync/opush/mail-backend-interfaces/src/test/java/org/obm/push/mail/bean/BeansTest.java
          Hide
          Thomas HILAIRE added a comment - - edited

          QA: follow reproduction steps, try to synchronize both attached .eml
          Impacts: global email sync but, we should be more focused on all kinds of attachement

          Show
          Thomas HILAIRE added a comment - - edited QA : follow reproduction steps, try to synchronize both attached .eml Impacts : global email sync but, we should be more focused on all kinds of attachement
          Hide
          Jenkins Continuous Integration Server added a comment -

          FAILURE: Integrated in poll-master #204
          OBMFULL-6437 OBMFULL-6428 Decoding fallback when no charset found (thilaire: 77071d4c43b898cf7408c16394f31e9a23da01b2)

          • java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java
          • java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java
            OBMFULL-6437 OBMFULL-6428 Removed unused key rewriter (thilaire: abe2662092b90f766bb81a338af1a5b188e6e0c7)
          • java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java
            OBMFULL-6437 OBMFULL-6428 BodyParam can now be grouped (thilaire: d9cefd0c2eb738ff119d12a813e270c6d1b8c976)
          • java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java
          • java/sync/linagora-imap/src/main/java/org/obm/push/mail/mime/BodyParam.java
          • java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/mime/impl/BodyParamParserTest.java
          • java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java
          • java/sync/linagora-imap/src/main/java/org/obm/push/mail/mime/BodyParams.java
          • java/sync/linagora-imap/src/test/java/org/obm/push/mail/bean/BeansTest.java
          Show
          Jenkins Continuous Integration Server added a comment - FAILURE: Integrated in poll-master #204 OBMFULL-6437 OBMFULL-6428 Decoding fallback when no charset found (thilaire: 77071d4c43b898cf7408c16394f31e9a23da01b2 ) java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java OBMFULL-6437 OBMFULL-6428 Removed unused key rewriter (thilaire: abe2662092b90f766bb81a338af1a5b188e6e0c7 ) java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java OBMFULL-6437 OBMFULL-6428 BodyParam can now be grouped (thilaire: d9cefd0c2eb738ff119d12a813e270c6d1b8c976 ) java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java java/sync/linagora-imap/src/main/java/org/obm/push/mail/mime/BodyParam.java java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/mime/impl/BodyParamParserTest.java java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java java/sync/linagora-imap/src/main/java/org/obm/push/mail/mime/BodyParams.java java/sync/linagora-imap/src/test/java/org/obm/push/mail/bean/BeansTest.java
          Hide
          Stephane COLSON added a comment -

          OK with version 2.5.11-0.alpha0+git20151008_1536_674807a

          Show
          Stephane COLSON added a comment - OK with version 2.5.11-0.alpha0+git20151008_1536_674807a
          Hide
          Jenkins Continuous Integration Server added a comment -

          SUCCESS: Integrated in poll-features-el7 #7
          OBMFULL-6437 OBMFULL-6428 Decoding fallback when no charset found (thilaire: 77071d4c43b898cf7408c16394f31e9a23da01b2)

          • java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java
          • java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java
            OBMFULL-6437 OBMFULL-6428 Removed unused key rewriter (thilaire: abe2662092b90f766bb81a338af1a5b188e6e0c7)
          • java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java
            OBMFULL-6437 OBMFULL-6428 BodyParam can now be grouped (thilaire: d9cefd0c2eb738ff119d12a813e270c6d1b8c976)
          • java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/mime/impl/BodyParamParserTest.java
          • java/sync/linagora-imap/src/main/java/org/obm/push/mail/mime/BodyParams.java
          • java/sync/linagora-imap/src/test/java/org/obm/push/mail/bean/BeansTest.java
          • java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java
          • java/sync/linagora-imap/src/main/java/org/obm/push/mail/mime/BodyParam.java
          • java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java
          Show
          Jenkins Continuous Integration Server added a comment - SUCCESS: Integrated in poll-features-el7 #7 OBMFULL-6437 OBMFULL-6428 Decoding fallback when no charset found (thilaire: 77071d4c43b898cf7408c16394f31e9a23da01b2 ) java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java OBMFULL-6437 OBMFULL-6428 Removed unused key rewriter (thilaire: abe2662092b90f766bb81a338af1a5b188e6e0c7 ) java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java OBMFULL-6437 OBMFULL-6428 BodyParam can now be grouped (thilaire: d9cefd0c2eb738ff119d12a813e270c6d1b8c976 ) java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/mime/impl/BodyParamParserTest.java java/sync/linagora-imap/src/main/java/org/obm/push/mail/mime/BodyParams.java java/sync/linagora-imap/src/test/java/org/obm/push/mail/bean/BeansTest.java java/sync/linagora-imap/src/main/java/org/obm/push/minig/imap/mime/impl/BodyParamParser.java java/sync/linagora-imap/src/main/java/org/obm/push/mail/mime/BodyParam.java java/sync/linagora-imap/src/test/java/org/obm/push/minig/imap/command/parser/BodyStructureParserTest.java

            People

            • Assignee:
              Thomas HILAIRE
              Reporter:
              Thomas HILAIRE
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: