Opush
  1. Opush
  2. OP-157

There is no display name in From field of emails sent by Opush

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Normal Normal
    • Resolution: Fixed
    • Affects Version/s: 3.0.4
    • Fix Version/s: 3.1.0
    • Labels:
      None
    • Story Points:
      2
    • Rank:
      6704

      Description

      Pre-conditions

      usera has been created with a firstname and a lastname in obm-ui

      Reproduction steps

      1. As usera, I send an email to myself using Opush
      2. As usera, I synchronize my INBOX and I see the new email

      Current behavior

      1. NOK, the From is the email address

      Expected behavior

      1. OK, the From is the display name (+ email address)

      Additional informations

        Activity

        Hide
        Thomas HILAIRE added a comment -

        The code can be found at stash-opush-thilaire/OP-157

        Show
        Thomas HILAIRE added a comment - The code can be found at stash-opush-thilaire/ OP-157
        Thomas HILAIRE made changes -
        Field Original Value New Value
        Sprint OBM Sprint 2015#2 [ 26 ]
        Thomas HILAIRE made changes -
        Rank Ranked lower
        David Dolcimascolo made changes -
        Story Points 2
        Stephane COLSON made changes -
        Sprint OBM Sprint 2015#2 [ 26 ]
        Ba Tuan NGO made changes -
        Assignee Thomas HILAIRE [ thilaire@linagora.com ] Ba Tuan NGO [ btngo@linagora.com ]
        Ba Tuan NGO made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Hide
        Ba Tuan NGO added a comment - - edited

        Impacts:
        _ Add display name in From field of email sent by OPUSH
        _ SendEmail uses now stronger type for from address.

        Tested on:
        opush_3.1.0~alpha0~git20150224.142438.7dc91bc-1 with obm 3.1.3-rc1 on Debian Wheezy. HTC One 4.4.2 and Iphone 8.1

        Tests done:
        The From field now has the form: Display name <email address>.

        Show
        Ba Tuan NGO added a comment - - edited Impacts : _ Add display name in From field of email sent by OPUSH _ SendEmail uses now stronger type for from address. Tested on : opush_3.1.0~alpha0~git20150224.142438.7dc91bc-1 with obm 3.1.3-rc1 on Debian Wheezy. HTC One 4.4.2 and Iphone 8.1 Tests done : The From field now has the form: Display name <email address>.
        Ba Tuan NGO made changes -
        Status In Progress [ 3 ] In Review [ 10001 ]
        Hide
        Jenkins Continuous Integration Server added a comment -

        SUCCESS: Integrated in opush-master #199
        OP-157 Add display name in From field (thilaire: d062acac9ad9baf83a9c6b6fcda99aeb1ff9cb6e)

        • push-mail/src/test/java/org/obm/push/mail/MailBackendTest.java
        • push-mail/src/test/java/org/obm/push/mail/MailBackendImplTest.java
        • integration-testing/opush/src/test/java/org/obm/opush/command/email/SmartReplyHandlerTest.java
        • push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java
          OP-157 Stronger type of from address in SendEmail (thilaire: 5937f31570d91a5469e7c96e5a4700a160d55850)
        • push-mail/src/test/java/org/obm/push/mail/SendEmailTest.java
        • push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java
        • push-mail/src/main/java/org/obm/push/mail/SendEmail.java
        • push-mail/src/main/java/org/obm/push/mail/ForwardEmail.java
        • push-mail/src/main/java/org/obm/push/mail/ReplyEmail.java
        • push-mail/src/test/java/org/obm/push/mail/ReplyEmailTest.java
        • push-mail/src/test/java/org/obm/push/mail/ForwardEmailTest.java
        Show
        Jenkins Continuous Integration Server added a comment - SUCCESS: Integrated in opush-master #199 OP-157 Add display name in From field (thilaire: d062acac9ad9baf83a9c6b6fcda99aeb1ff9cb6e ) push-mail/src/test/java/org/obm/push/mail/MailBackendTest.java push-mail/src/test/java/org/obm/push/mail/MailBackendImplTest.java integration-testing/opush/src/test/java/org/obm/opush/command/email/SmartReplyHandlerTest.java push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java OP-157 Stronger type of from address in SendEmail (thilaire: 5937f31570d91a5469e7c96e5a4700a160d55850 ) push-mail/src/test/java/org/obm/push/mail/SendEmailTest.java push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java push-mail/src/main/java/org/obm/push/mail/SendEmail.java push-mail/src/main/java/org/obm/push/mail/ForwardEmail.java push-mail/src/main/java/org/obm/push/mail/ReplyEmail.java push-mail/src/test/java/org/obm/push/mail/ReplyEmailTest.java push-mail/src/test/java/org/obm/push/mail/ForwardEmailTest.java
        Thomas HILAIRE made changes -
        Status In Review [ 10001 ] Ready To Merge [ 10002 ]
        Resolution Fixed [ 1 ]
        Thomas HILAIRE made changes -
        Status Ready To Merge [ 10002 ] Resolved [ 5 ]
        Hide
        Stephane COLSON added a comment -

        OK with version 3.1.0~alpha0~git20150327.162644.3b1273a-1

        Tested with iPhone (iOS7), Windows Phone 8, Nexus 7 (Android 5.1), Fairphone FP1 (Android 4.2.2)

        Show
        Stephane COLSON added a comment - OK with version 3.1.0~alpha0~git20150327.162644.3b1273a-1 Tested with iPhone (iOS7), Windows Phone 8, Nexus 7 (Android 5.1), Fairphone FP1 (Android 4.2.2)
        Stephane COLSON made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Thomas HILAIRE added a comment -

        KO by adding "strict_rfc821_envelopes = yes" in your postfix main.cf configuration file, users won't be able to send email anymore.

        Show
        Thomas HILAIRE added a comment - KO by adding "strict_rfc821_envelopes = yes" in your postfix main.cf configuration file, users won't be able to send email anymore.
        Thomas HILAIRE made changes -
        Resolution Fixed [ 1 ]
        Status Closed [ 6 ] Reopened [ 4 ]
        Thomas HILAIRE made changes -
        Assignee Ba Tuan NGO [ btngo@linagora.com ] Thomas HILAIRE [ thilaire@linagora.com ]
        Thomas HILAIRE made changes -
        Status Reopened [ 4 ] In Progress [ 3 ]
        Thomas HILAIRE made changes -
        Status In Progress [ 3 ] In Review [ 10001 ]
        Hide
        Jenkins Continuous Integration Server added a comment -

        ABORTED: Integrated in opush-master #233
        OP-157 Don't give FROM displayName to the SMTP client (thilaire: e72765d7d3ffa8a2ae05e15f96bc4300b7060ed0)

        • push-mail/src/test/java/org/obm/push/mail/ReplyEmailTest.java
        • push-mail/src/main/java/org/obm/push/mail/smtp/SmtpSenderImpl.java
        • push-mail/src/test/java/org/obm/push/mail/SendEmailTest.java
        • push-mail/src/test/java/org/obm/push/mail/MailBackendImplTest.java
        • push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java
        • push-mail/src/main/java/org/obm/push/mail/SendEmail.java
        Show
        Jenkins Continuous Integration Server added a comment - ABORTED: Integrated in opush-master #233 OP-157 Don't give FROM displayName to the SMTP client (thilaire: e72765d7d3ffa8a2ae05e15f96bc4300b7060ed0 ) push-mail/src/test/java/org/obm/push/mail/ReplyEmailTest.java push-mail/src/main/java/org/obm/push/mail/smtp/SmtpSenderImpl.java push-mail/src/test/java/org/obm/push/mail/SendEmailTest.java push-mail/src/test/java/org/obm/push/mail/MailBackendImplTest.java push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java push-mail/src/main/java/org/obm/push/mail/SendEmail.java
        Hide
        Thomas HILAIRE added a comment -

        QA: Same things with and without the "strict_rfc821_envelopes = yes"
        Impacts: Send, reply or forward an email

        Show
        Thomas HILAIRE added a comment - QA : Same things with and without the "strict_rfc821_envelopes = yes" Impacts : Send, reply or forward an email
        Thomas HILAIRE made changes -
        Status In Review [ 10001 ] Ready To Merge [ 10002 ]
        Resolution Fixed [ 1 ]
        Thomas HILAIRE made changes -
        Status Ready To Merge [ 10002 ] Resolved [ 5 ]
        Hide
        Stephane COLSON added a comment -

        OK with or without the option.
        Tested on a CentOS with OBM 3.1.5-0.rc3 & Opush 3.1.0~rc2 with iPad and Nexus 7

        Show
        Stephane COLSON added a comment - OK with or without the option. Tested on a CentOS with OBM 3.1.5-0.rc3 & Opush 3.1.0~rc2 with iPad and Nexus 7
        Stephane COLSON made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Thomas HILAIRE
            Reporter:
            Thomas HILAIRE
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved: