Opush
  1. Opush
  2. OP-189

Allday event date can be moved on the device when something modified by obm-ui

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Normal Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.1.0
    • Labels:
      None
    • Rank:
      6804

      Description

      Pre-conditions

      1. Have usera with a motog 4.4.4 device on Europe/Athens
      2. Have usera with obm-ui on Europe/Athens

      Reproduction steps

      1. As usera with motog, create an allday event, synchronize
      2. As usera with ui, modify the name of this event
      3. As usera with motog, synchronize

      Current behavior

      1. NOK the event is displayed over two days the device

      Expected behavior

      1. OK the event name is changed and it appears at the right day on the device

      Additional informations

        Issue Links

          Activity

          Hide
          Thomas HILAIRE added a comment -

          QA: For me it's OK with the iPhone7.1.2 because

          • it works correctly with Europe/Paris TZ
          • we know that we have TZ issue with iOS because their TZ definition don't match Android's ones. In this case, we don't recognize the Athens TZ.
          • as you said it was not working anymore with Opush 3.0.6, so it's a timezone issue which is not related with this ticket
          Show
          Thomas HILAIRE added a comment - QA : For me it's OK with the iPhone7.1.2 because it works correctly with Europe/Paris TZ we know that we have TZ issue with iOS because their TZ definition don't match Android's ones. In this case, we don't recognize the Athens TZ. as you said it was not working anymore with Opush 3.0.6, so it's a timezone issue which is not related with this ticket
          Hide
          Antoine DUPRAT added a comment -

          iPhone, 7.1.2 NOK on Opush 3.0.6

          Show
          Antoine DUPRAT added a comment - iPhone, 7.1.2 NOK on Opush 3.0.6
          Hide
          Antoine DUPRAT added a comment -

          NOK
          Tested on Debian wheezy with Opush 3.1.0~alpha0~git20150327.162644.3b1273a & OBM 3.1.4~1

          Android iOS
          Nexus 4, 5.0.1 OK iPhone, 5.1.1 OK
          Galaxy S2, 4.1.2 OK iPhone, 7.1.2 NOK

          When creating a allday event on iPhone 7.1.2, it appears the day before in obm-ui.

          Creation request sent:

          <?xml version="1.0" encoding="UTF-8"?><Sync>
          <Collections>
          <Collection>
          <SyncKey>544e8f64-797c-432e-92c7-4d066a39196a</SyncKey>
          <CollectionId>1</CollectionId>
          <GetChanges/>
          <WindowSize>25</WindowSize>
          <Options>
          <FilterType>5</FilterType>
          <BodyPreference>
          <Type>1</Type>
          <TruncationSize>32768</TruncationSize>
          </BodyPreference>
          </Options>
          <Commands>
          <Add>
          <ClientId>12571</ClientId>
          <ApplicationData>
          <TimeZone>iP///wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAoAAAAFAAMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA
          AAAAAMAAAAFAAQAAAAAAAAAxP///w==</TimeZone>
          <AllDayEvent>1</AllDayEvent>
          <BusyStatus>2</BusyStatus>
          <DTStamp>20150331T091559Z</DTStamp>
          <EndTime>20150404T210000Z</EndTime>
          <Sensitivity>0</Sensitivity>
          <Subject>Cest3</Subject>
          <StartTime>20150403T210000Z</StartTime>
          <UID>77C078158E2642C4B66696D7FA8F742D00000000000000000000000000000000</UID>
          <MeetingStatus>0</MeetingStatus>
          </ApplicationData>
          </Add>
          </Commands>
          </Collection>
          </Collections>
          </Sync>
          

          Creation in obm-sync:

          <?xml version="1.0" encoding="UTF-8"?>
          <event xmlns="http://www.obm.org/xsd/sync/event.xsd" allDay="true" anonymized="false" isInternal="true" sequence="0" type="VEVENT">
              <hash>845155007</hash><timeupdate>1427793359000</timeupdate><timecreate>1427793359000</timecreate><extId>7218bfb1-789a-49bd-9172-59fcccc7dd5d</extId><opacity>OPAQUE</opacity><title>Cest3</title><ownerEmail>userc@adupratvm.lyon.lan</ownerEmail><date>1428094800000</date><duration>86400</duration><priority>0</priority><privacy>0</privacy>
              <attendees>
                  <attendee displayName="userc" email="userc@adupratvm.lyon.lan" isOrganizer="true" percent="0" required="REQ" state="ACCEPTED"/>
              </attendees>
              <recurrence kind="none"/>
          </event>
          

          obm-sync getSync response:

          <?xml version="1.0" encoding="UTF-8"?><calendar-changes xmlns="http://www.obm.org/xsd/sync/calendar-changes.xsd" lastSync="1427793362548">
          <removed/>
          <updated>
          <event allDay="true" anonymized="false" id="41" isInternal="true" sequence="0" type="VEVENT">
          <hash>95275590</hash>
          <timecreate>1427793362401</timecreate>
          <extId>7218bfb1-789a-49bd-9172-59fcccc7dd5d</extId>
          <opacity>OPAQUE</opacity>
          <title>Cest3</title>
          <owner>userc</owner>
          <ownerEmail>userc@adupratvm.lyon.lan</ownerEmail>
          <tz>Europe/Paris</tz>
          <date>1428094800000</date>
          <duration>86400</duration>
          <priority>0</priority>
          <privacy>0</privacy>
          <attendees>
          <attendee displayName="userc" email="userc@adupratvm.lyon.lan" isOrganizer="true" percent="0" required="REQ" state="ACCEPTED"/>
          </attendees>
          <recurrence kind="none"/>
          </event>
          </updated>
          <participationChanges/>
          </calendar-changes>
          
          Show
          Antoine DUPRAT added a comment - NOK Tested on Debian wheezy with Opush 3.1.0~alpha0~git20150327.162644.3b1273a & OBM 3.1.4~1 Android iOS Nexus 4, 5.0.1 OK iPhone, 5.1.1 OK Galaxy S2, 4.1.2 OK iPhone, 7.1.2 NOK When creating a allday event on iPhone 7.1.2, it appears the day before in obm-ui. Creation request sent: <?xml version= "1.0" encoding= "UTF-8" ?><Sync> <Collections> <Collection> <SyncKey>544e8f64-797c-432e-92c7-4d066a39196a</SyncKey> <CollectionId>1</CollectionId> <GetChanges/> <WindowSize>25</WindowSize> <Options> <FilterType>5</FilterType> <BodyPreference> <Type>1</Type> <TruncationSize>32768</TruncationSize> </BodyPreference> </Options> <Commands> <Add> <ClientId>12571</ClientId> <ApplicationData> <TimeZone>iP ///wAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAoAAAAFAAMAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA AAAAAMAAAAFAAQAAAAAAAAAxP ///w==</TimeZone> <AllDayEvent>1</AllDayEvent> <BusyStatus>2</BusyStatus> <DTStamp>20150331T091559Z</DTStamp> <EndTime>20150404T210000Z</EndTime> <Sensitivity>0</Sensitivity> <Subject>Cest3</Subject> <StartTime>20150403T210000Z</StartTime> <UID>77C078158E2642C4B66696D7FA8F742D00000000000000000000000000000000</UID> <MeetingStatus>0</MeetingStatus> </ApplicationData> </Add> </Commands> </Collection> </Collections> </Sync> Creation in obm-sync: <?xml version= "1.0" encoding= "UTF-8" ?> <event xmlns= "http: //www.obm.org/xsd/sync/event.xsd" allDay= " true " anonymized= " false " isInternal= " true " sequence= "0" type= "VEVENT" > <hash>845155007</hash><timeupdate>1427793359000</timeupdate><timecreate>1427793359000</timecreate><extId>7218bfb1-789a-49bd-9172-59fcccc7dd5d</extId><opacity>OPAQUE</opacity><title>Cest3</title><ownerEmail>userc@adupratvm.lyon.lan</ownerEmail><date>1428094800000</date><duration>86400</duration><priority>0</priority><privacy>0</privacy> <attendees> <attendee displayName= "userc" email= "userc@adupratvm.lyon.lan" isOrganizer= " true " percent= "0" required= "REQ" state= "ACCEPTED" /> </attendees> <recurrence kind= "none" /> </event> obm-sync getSync response: <?xml version= "1.0" encoding= "UTF-8" ?><calendar-changes xmlns= "http: //www.obm.org/xsd/sync/calendar-changes.xsd" lastSync= "1427793362548" > <removed/> <updated> <event allDay= " true " anonymized= " false " id= "41" isInternal= " true " sequence= "0" type= "VEVENT" > <hash>95275590</hash> <timecreate>1427793362401</timecreate> <extId>7218bfb1-789a-49bd-9172-59fcccc7dd5d</extId> <opacity>OPAQUE</opacity> <title>Cest3</title> <owner>userc</owner> <ownerEmail>userc@adupratvm.lyon.lan</ownerEmail> <tz>Europe/Paris</tz> <date>1428094800000</date> <duration>86400</duration> <priority>0</priority> <privacy>0</privacy> <attendees> <attendee displayName= "userc" email= "userc@adupratvm.lyon.lan" isOrganizer= " true " percent= "0" required= "REQ" state= "ACCEPTED" /> </attendees> <recurrence kind= "none" /> </event> </updated> <participationChanges/> </calendar-changes>
          Hide
          Jenkins Continuous Integration Server added a comment -

          UNSTABLE: Integrated in opush-master #218
          OP-189 OP-188 The obm-sync value is already right (thilaire: 49f611ab0f607d284d987c6e461c1078316a17bf)

          • obm-backend/src/test/java/org/obm/push/calendar/ConvertObmEventToMsEventIntegrityTest.java
          • obm-backend/src/test/java/org/obm/push/calendar/ConvertObmEventByICSLoopTest.java
          • obm-backend/src/main/java/org/obm/push/calendar/ObmEventToMSEventConverterImpl.java
          Show
          Jenkins Continuous Integration Server added a comment - UNSTABLE: Integrated in opush-master #218 OP-189 OP-188 The obm-sync value is already right (thilaire: 49f611ab0f607d284d987c6e461c1078316a17bf ) obm-backend/src/test/java/org/obm/push/calendar/ConvertObmEventToMsEventIntegrityTest.java obm-backend/src/test/java/org/obm/push/calendar/ConvertObmEventByICSLoopTest.java obm-backend/src/main/java/org/obm/push/calendar/ObmEventToMSEventConverterImpl.java

            People

            • Assignee:
              Thomas HILAIRE
              Reporter:
              Thomas HILAIRE
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: