Opush
  1. Opush
  2. OP-237

Opush accepts to boot even when it cannot reach the database

    Details

    • Type: Bug Bug
    • Status: Closed Closed
    • Priority: Normal Normal
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.2.0
    • Labels:
      None
    • Story Points:
      1
    • Rank:
      6990
    • Sprint:
      2016#01

      Description

      Pre-conditions

      Reproduction steps

      1. As an admin, I set a wrong db information in /etc/opush/opush.ini or /etc/obm/obm_conf.ini
      2. I restart opush

      Current behavior

      1. NOK it listens on the port 8082
      2. NOK I can administrate opush using crash

      Expected behavior

      1. OK it doesn't listen on the port 8082
      2. OK I can't administrate opush using crash
      3. OK I have some logs in opush.log telling that opush won't start

      Additional informations

        Activity

        Thomas HILAIRE made changes -
        Field Original Value New Value
        Description h4. Pre-conditions

        h4. Reproduction steps
        # As an admin, I set a wrong db information in /etc/opush/opush.ini or /etc/obm/obm_conf.ini
        # I restart opush

        h4. Current behavior
        # {color:red}NOK{color} it listens on the port 8082
        # {color:red}NOK{color} I can administrate opush using crash

        h4. Expected behavior
        # {color:green}OK{color} it doesn't listen on the port 8082
        # {color:green}OK{color} I can't administrate opush using crash

        h4. Additional informations
        h4. Pre-conditions

        h4. Reproduction steps
        # As an admin, I set a wrong db information in /etc/opush/opush.ini or /etc/obm/obm_conf.ini
        # I restart opush

        h4. Current behavior
        # {color:red}NOK{color} it listens on the port 8082
        # {color:red}NOK{color} I can administrate opush using crash

        h4. Expected behavior
        # {color:green}OK{color} it doesn't listen on the port 8082
        # {color:green}OK{color} I can't administrate opush using crash
        # {color:green}OK{color} I have some logs in opush.log telling that opush won't start

        h4. Additional informations
        Thomas HILAIRE made changes -
        Sprint 2016#01 [ 30 ]
        Thomas HILAIRE made changes -
        Story Points 1
        Thomas HILAIRE made changes -
        Fix Version/s 3.1.2 [ 13200 ]
        Thomas HILAIRE made changes -
        Status Open [ 1 ] In Progress [ 3 ]
        Thomas HILAIRE made changes -
        Status In Progress [ 3 ] In Review [ 10001 ]
        Hide
        Thomas HILAIRE added a comment -

        Impacts: The opush startup
        QA: I've tested on a debian that:

        • opush won't start at all if the DB cannot be reached (bad ip, bad password, ...)
        • opush will start as "admin mode" if the DB can be reached, but "cassandra schema version" is not as expected
        • opush starts and serve requests if the DB can be reached, and the "cassandra schema version" is as expected
        Show
        Thomas HILAIRE added a comment - Impacts : The opush startup QA : I've tested on a debian that: opush won't start at all if the DB cannot be reached (bad ip, bad password, ...) opush will start as "admin mode" if the DB can be reached, but "cassandra schema version" is not as expected opush starts and serve requests if the DB can be reached, and the "cassandra schema version" is as expected
        Hide
        Jenkins Continuous Integration Server added a comment -

        UNSTABLE: Integrated in opush-master-3.1 #44
        OP-237 Exit with a message if the db isn't reachable (thilaire: 47dfa665e5a6c5c2d6e04841238b3bfcbd22542c)

        • push-server/src/main/java/org/obm/push/ServerFactoryModule.java
        • integration-testing/opush/src/main/java/org/obm/opush/env/DaoModule.java
        • push-server/src/test/java/org/obm/push/ServerFactoryModuleTest.java
        • push-server/src/main/java/org/obm/push/OpushServerLauncher.java
        Show
        Jenkins Continuous Integration Server added a comment - UNSTABLE: Integrated in opush-master-3.1 #44 OP-237 Exit with a message if the db isn't reachable (thilaire: 47dfa665e5a6c5c2d6e04841238b3bfcbd22542c ) push-server/src/main/java/org/obm/push/ServerFactoryModule.java integration-testing/opush/src/main/java/org/obm/opush/env/DaoModule.java push-server/src/test/java/org/obm/push/ServerFactoryModuleTest.java push-server/src/main/java/org/obm/push/OpushServerLauncher.java
        Thomas HILAIRE made changes -
        Status In Review [ 10001 ] Ready To Merge [ 10002 ]
        Resolution Fixed [ 1 ]
        Thomas HILAIRE made changes -
        Status Ready To Merge [ 10002 ] Resolved [ 5 ]
        Hide
        Stephane COLSON added a comment -

        OK on CentOS and Debian

        Show
        Stephane COLSON added a comment - OK on CentOS and Debian
        Stephane COLSON made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Hide
        Jenkins Continuous Integration Server added a comment -

        ABORTED: Integrated in opush-master #262
        OP-237 Exit with a message if the db isn't reachable (thilaire: b6c6bbcacbc8476a31f54cddfe1925a5308df87e)

        • push-server/src/test/java/org/obm/push/ServerFactoryModuleTest.java
        • integration-testing/opush/src/main/java/org/obm/opush/env/DaoModule.java
        • push-server/src/main/java/org/obm/push/OpushServerLauncher.java
        • push-server/src/main/java/org/obm/push/ServerFactoryModule.java
        Show
        Jenkins Continuous Integration Server added a comment - ABORTED: Integrated in opush-master #262 OP-237 Exit with a message if the db isn't reachable (thilaire: b6c6bbcacbc8476a31f54cddfe1925a5308df87e ) push-server/src/test/java/org/obm/push/ServerFactoryModuleTest.java integration-testing/opush/src/main/java/org/obm/opush/env/DaoModule.java push-server/src/main/java/org/obm/push/OpushServerLauncher.java push-server/src/main/java/org/obm/push/ServerFactoryModule.java

          People

          • Assignee:
            Thomas HILAIRE
            Reporter:
            Thomas HILAIRE
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile