Opush
  1. Opush
  2. OP-64

T#10535 Support configuring the max number of results returned by a LDAP search

    Details

    • Type: Improvement Improvement
    • Status: Closed Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0
    • Fix Version/s: 3.0.2
    • Labels:
    • Story Points:
      3.5
    • Rank:
      6292
    • Sprint:
      Sprint

      Description

      We should allow limiting by configuration the number fo results returned by opush via an LDAP search.

      Reproduction steps:

      • have 5 users: usera, userb, userc, userd, usere
      • edit your ldap limit: in /etc/ldap/slapd.conf set the "sizelimit" to 3
      • with a device, begin to write an email and start typing "user" in the "To"
      • a "search" command is performed against opush

      Current behavior:

      • opush reply well to the device but an exception is printed is the opush.log file KO

      Expeced behavior:

      • opush reply well to the device and no exception is printed is the opush.log file KO
      • in /etc/opush/ldap_conf.ini, set search.ldap.limit=2: only two items should be replied by opush

        Issue Links

          Activity

          David Dolcimascolo made changes -
          Field Original Value New Value
          Issue Type Bug [ 1 ] Improvement [ 4 ]
          David Dolcimascolo made changes -
          Priority Normal [ 6 ] Minor [ 4 ]
          David Dolcimascolo made changes -
          Description You should probably use this :http://docs.oracle.com/javase/7/docs/api/javax/naming/directory/SearchControls.html#setCountLimit(long) We should allow limiting by configuration the number fo results returned by opush via an LDAP search.
          David Dolcimascolo made changes -
          Labels 201409 GN
          David Dolcimascolo made changes -
          Story Points 3.5
          David Dolcimascolo made changes -
          Sprint Sprint [ 23 ]
          Thomas HILAIRE made changes -
          Assignee Matthieu BAECHLER [ mbaechler@linagora.com ] Thomas HILAIRE [ thilaire@linagora.com ]
          Thomas HILAIRE made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Thomas HILAIRE made changes -
          Link This issue relates to OBMFULL-6112 [ OBMFULL-6112 ]
          Thomas HILAIRE made changes -
          Status In Progress [ 3 ] In Review [ 10001 ]
          Hide
          Thomas HILAIRE added a comment -

          QA: verify the expected behavior, play with different values in the ldap config and the opush's ldap limit to check that there is no more exception
          Impacts:

          • (few impact) users research when devices want "users/contacts" autocompletion
          • (higher impact) OBM dependencies have been updated, the global opush behavior can be impacted
          Show
          Thomas HILAIRE added a comment - QA : verify the expected behavior, play with different values in the ldap config and the opush's ldap limit to check that there is no more exception Impacts : (few impact) users research when devices want "users/contacts" autocompletion (higher impact) OBM dependencies have been updated, the global opush behavior can be impacted
          Thomas HILAIRE made changes -
          Fix Version/s 3.0.2 [ 12410 ]
          Description We should allow limiting by configuration the number fo results returned by opush via an LDAP search. We should allow limiting by configuration the number fo results returned by opush via an LDAP search.

          *Reproduction steps*:
          - have 5 users: usera, userb, userc, userd, usere
          - edit your ldap limit: in /etc/ldap/slapd.conf set the "sizelimit" to 3
          - with a device, begin to write an email and start typing "user" in the "To"
          - a "search" command is performed against opush

          *Current behavior*:
          - opush reply well to the device but an exception is printed is the opush.log file {color:red}KO{color}

          *Expeced behavior*:
          - opush reply well to the device and no exception is printed is the opush.log file {color:green}KO{color}
          - in /etc/opush/ldap_conf.ini, set search.ldap.limit=2: only two items should be replied by opush
          Thomas HILAIRE made changes -
          Status In Review [ 10001 ] Ready To Merge [ 10002 ]
          Resolution Fixed [ 1 ]
          Thomas HILAIRE made changes -
          Status Ready To Merge [ 10002 ] Resolved [ 5 ]
          Hide
          Antoine DUPRAT added a comment -

          OK with version 3.0.2~beta2~git20141003.123458.7d754f8-1
          Tested on Debian Wheezy 3.2.46-1+deb7u1

          Show
          Antoine DUPRAT added a comment - OK with version 3.0.2~beta2~git20141003.123458.7d754f8-1 Tested on Debian Wheezy 3.2.46-1+deb7u1
          Antoine DUPRAT made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Thomas HILAIRE
              Reporter:
              David Dolcimascolo
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Agile