[OP-157] There is no display name in From field of emails sent by Opush Created: 19/Jan/15  Updated: 21/May/15  Resolved: 20/May/15

Status: Closed
Project: Opush
Component/s: None
Affects Version/s: 3.0.4
Fix Version/s: 3.1.0

Type: Improvement Priority: Normal
Reporter: Thomas HILAIRE Assignee: Thomas HILAIRE
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Story Points: 2
Rank: 6704

 Description   

Pre-conditions

usera has been created with a firstname and a lastname in obm-ui

Reproduction steps

  1. As usera, I send an email to myself using Opush
  2. As usera, I synchronize my INBOX and I see the new email

Current behavior

  1. NOK, the From is the email address

Expected behavior

  1. OK, the From is the display name (+ email address)

Additional informations



 Comments   
Comment by Thomas HILAIRE [ 19/Jan/15 ]

The code can be found at stash-opush-thilaire/OP-157

Comment by Ba Tuan NGO [ 25/Feb/15 ]

Impacts:
_ Add display name in From field of email sent by OPUSH
_ SendEmail uses now stronger type for from address.

Tested on:
opush_3.1.0~alpha0~git20150224.142438.7dc91bc-1 with obm 3.1.3-rc1 on Debian Wheezy. HTC One 4.4.2 and Iphone 8.1

Tests done:
The From field now has the form: Display name <email address>.

Comment by Jenkins Continuous Integration Server [ 11/Mar/15 ]

SUCCESS: Integrated in opush-master #199
OP-157 Add display name in From field (thilaire: d062acac9ad9baf83a9c6b6fcda99aeb1ff9cb6e)

  • push-mail/src/test/java/org/obm/push/mail/MailBackendTest.java
  • push-mail/src/test/java/org/obm/push/mail/MailBackendImplTest.java
  • integration-testing/opush/src/test/java/org/obm/opush/command/email/SmartReplyHandlerTest.java
  • push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java
    OP-157 Stronger type of from address in SendEmail (thilaire: 5937f31570d91a5469e7c96e5a4700a160d55850)
  • push-mail/src/test/java/org/obm/push/mail/SendEmailTest.java
  • push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java
  • push-mail/src/main/java/org/obm/push/mail/SendEmail.java
  • push-mail/src/main/java/org/obm/push/mail/ForwardEmail.java
  • push-mail/src/main/java/org/obm/push/mail/ReplyEmail.java
  • push-mail/src/test/java/org/obm/push/mail/ReplyEmailTest.java
  • push-mail/src/test/java/org/obm/push/mail/ForwardEmailTest.java
Comment by Stephane COLSON [ 03/Apr/15 ]

OK with version 3.1.0~alpha0~git20150327.162644.3b1273a-1

Tested with iPhone (iOS7), Windows Phone 8, Nexus 7 (Android 5.1), Fairphone FP1 (Android 4.2.2)

Comment by Thomas HILAIRE [ 20/May/15 ]

KO by adding "strict_rfc821_envelopes = yes" in your postfix main.cf configuration file, users won't be able to send email anymore.

Comment by Jenkins Continuous Integration Server [ 20/May/15 ]

ABORTED: Integrated in opush-master #233
OP-157 Don't give FROM displayName to the SMTP client (thilaire: e72765d7d3ffa8a2ae05e15f96bc4300b7060ed0)

  • push-mail/src/test/java/org/obm/push/mail/ReplyEmailTest.java
  • push-mail/src/main/java/org/obm/push/mail/smtp/SmtpSenderImpl.java
  • push-mail/src/test/java/org/obm/push/mail/SendEmailTest.java
  • push-mail/src/test/java/org/obm/push/mail/MailBackendImplTest.java
  • push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java
  • push-mail/src/main/java/org/obm/push/mail/SendEmail.java
Comment by Thomas HILAIRE [ 20/May/15 ]

QA: Same things with and without the "strict_rfc821_envelopes = yes"
Impacts: Send, reply or forward an email

Comment by Stephane COLSON [ 21/May/15 ]

OK with or without the option.
Tested on a CentOS with OBM 3.1.5-0.rc3 & Opush 3.1.0~rc2 with iPad and Nexus 7

Generated at Wed Aug 21 02:39:25 CEST 2019 using JIRA 6.1.1#6155-sha1:7188aeec9a6b57d61ea04c52f235f15f55c105e2.