[OP-168] Wrong item synchronization state when many changes are discovered at the same time Created: 10/Feb/15  Updated: 31/Mar/15  Resolved: 16/Mar/15

Status: Closed
Project: Opush
Component/s: None
Affects Version/s: 3.0.6
Fix Version/s: 3.1.0

Type: Bug Priority: Normal
Reporter: Thomas HILAIRE Assignee: Ba Tuan NGO
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Issue Links:
Relates
relates to OP-143 No sync of modified event during down... Closed
Rank: 6758

 Description   

Pre-conditions

Find the "WindowSize" of the tested device for the tested collection.
1) synchronize the collection that you want to test, e.g. INBOX, calendar, contacts, etc
2) search in your opush logs the <WindowSize>10</WindowSize> sent by your device.
3) in the reproduction steps, XX is the window size of the collection. Here it's 10.

Note that your device has a different window size for every collection type

Reproduction steps

For the calendar test

  1. As usera with obm-ui, create XX+5 events for tomorrow

For the address book test

  1. As usera with obm-ui, create XX+5 contacts

For the email test

  1. As usera I send XX+5 emails to himself

Then

  1. As usera with a device, I synchronize my collection and receive all new items
  2. As usera from obm-ui, I delete all created items but one
  3. As usera from obm-ui, I modify the remaining item
  4. As usera from obm-ui, I create one new item
  5. As usera with a device, I synchronize my collection

Current behavior

  1. OK, the change and the new item is received
  2. NOK, some items have not been deleted from my device

Expected behavior

  1. OK, the change and the new item is received
  2. OK, every item is deleted from my device

Additional informations



 Comments   
Comment by Thomas HILAIRE [ 10/Feb/15 ]

WIP: Tests and code are available at stash-opush-thilaire/OP-168

Comment by Ba Tuan NGO [ 09/Mar/15 ]

Impacts:
_ Windowing should add all changes (new-change-delete).

Tested on:
_ opush_3.1.0~alpha0~git20150302.183202.5f72bfc-1 with obm 3.1.3-rc1 on Debian Wheezy. HTC One 4.4.2 and Android 4.4.2

Tests done:
_ Every changes from the server are synchronized.

Comment by Jenkins Continuous Integration Server [ 13/Mar/15 ]

ABORTED: Integrated in opush-master #206
OP-168 Windowing adds all changes (thilaire: 5665c03e12ebda969ed8543fe57deff9a957ecdc)

  • integration-testing/opush/src/test/resources/org/obm/opush/windowing/windowing.feature
  • push-dao-testsuite/src/main/java/org/obm/push/dao/testsuite/WindowingDaoTest.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/dao/WindowingDaoCassandraImpl.java
  • integration-testing/opush/src/test/java/org/obm/opush/windowing/WindowingStepdefs.java
  • integration-testing/opush/src/test/java/org/obm/opush/command/sync/SyncHandlerWithBackendTest.java
Comment by Jenkins Continuous Integration Server [ 13/Mar/15 ]

ABORTED: Integrated in opush-master #207
OP-168 Windowing adds all changes (thilaire: 2e2ccffd2c6ce6ba68168a53491aff109fe180a5)

  • integration-testing/opush/src/test/java/org/obm/opush/windowing/WindowingStepdefs.java
  • push-dao-testsuite/src/main/java/org/obm/push/dao/testsuite/WindowingDaoTest.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/dao/WindowingDaoCassandraImpl.java
  • integration-testing/opush/src/test/java/org/obm/opush/command/sync/SyncHandlerWithBackendTest.java
  • integration-testing/opush/src/test/resources/org/obm/opush/windowing/windowing.feature
Comment by Antoine DUPRAT [ 31/Mar/15 ]

OK

Tested on Debian wheezy with Opush 3.1.0~alpha0~git20150327.162644.3b1273a on Nexus 4 (5.0.1)

Generated at Fri Oct 18 13:04:04 CEST 2019 using JIRA 6.1.1#6155-sha1:7188aeec9a6b57d61ea04c52f235f15f55c105e2.