[OP-231] Some changes can be missed when a device use twice the same synckey Created: 11/Feb/16  Updated: 04/Jul/17  Resolved: 27/Apr/16

Status: Closed
Project: Opush
Component/s: None
Affects Version/s: None
Fix Version/s: 3.2.0

Type: Bug Priority: Normal
Reporter: Thomas HILAIRE Assignee: Thomas HILAIRE
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Attachments: HTML File notDeletedEmail    
Story Points: 6
Rank: 6964
Sprint: 2016#01

 Description   

Some changes can be missed when a device use twice the same synckey

Reproduction steps

None, this can be hard to reproduce but you can try these steps:

  • synchronize usera emails with a device
  • cut the device network
  • send to usera a bunch of 1000 emails
  • reconnect the device network
  • as soon as it starts to make a request (see logs), cut the network again
  • reconnect the device network
  • let the device synchronize a bunch of new emails (~100 emails)
  • make some changes with another MUA (tb, roundcube, ..) like deletions or read status updates

Current behavior

  1. NOK deletions are not took in account by the device, even by forcing new syncs

Expected behavior

  1. OK deletions are took in account by the device, may be that you will need to force new syncs

Note:
I've written tests for this jira, I've also tried a fix but we should evaluate another way to make that. See thilaire/OP-231



 Comments   
Comment by Thomas HILAIRE [ 26/Apr/16 ]

QA: tested with a GS6:

  • sync many emails : send 1000 emails, sync them and wait to have all on the device, then
    • make changes from the mobile
    • make changes from the server
    • make changes from the server on older items than these 1000 ones
  • make changes during the sync of many emails : send 1000 emails, sync them and don't wait to have all on the device to make during the synchronization:
    • some changes on emails like deletions and read status
    • down the network, up again, down again, ...
  • verify the "reproduction steps"
  • upgrade opush during a big email sync of an user : be in a previous opush version
    • send 1000 emails
    • start to sync them
    • stop opush and install the new version
    • make some changes on emails
    • continue to sync

Impacts: email synchronization

Comment by Thomas HILAIRE [ 26/Apr/16 ]

TIP: To send many emails to an user

for i in {1..1000}; do echo "Subject: $i - $(date) " | sendmail -F from@domain -t to@domain; done;
Comment by Jenkins Continuous Integration Server [ 26/Apr/16 ]

UNSTABLE: Integrated in opush-master-3.1 #48
OP-231 Add device id to the AUTH loggger (thilaire: a23a73c2f87b068d6d23aa59c1248417ba8d3c69)

  • push-core/src/main/java/org/obm/push/ActiveSyncServlet.java
    OP-231 Do not miss changes when the device get back with the same SK (thilaire: fe2ab0b0bb3198689b1c653f0fdb2d250aa198f0)
  • push-server/src/main/java/org/obm/push/migration/MigrationModule.java
  • push-mail/src/test/java/org/obm/push/mail/MailBackendSyncDataTest.java
  • push-mail/src/test/java/org/obm/push/mail/MailBackendImplTest.java
  • push-mail/src/test/java/org/obm/push/mail/MailboxBackendTest.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/dao/WindowingToSnapshotDaoCassandraImpl.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/dao/CassandraStructure.java
  • push-dao-mail/src/main/java/org/obm/push/store/WindowingToSnapshotDao.java
  • push-dao-mail/src/main/java/org/obm/push/store/SnapshotDao.java
  • push-mail/src/test/java/org/obm/push/mail/MailBackendTest.java
  • integration-testing/opush/src/test/java/org/obm/opush/MailBackendGetChangedTest.java
  • push-server/src/main/resources/versions/6/windowing_to_snapshot.cql
  • push-core/src/test/java/org/obm/push/ActiveSyncServletTest.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/dao/SnapshotDaoCassandraImpl.java
  • push-dao-cassandra/src/test/java/org/obm/push/cassandra/dao/WindowingToSnapshotDaoCassandraImplTest.java
  • push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java
  • push-mail/src/main/java/org/obm/push/mail/MailBackendSyncData.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/OpushCassandraModule.java
  • push-dao-testsuite/src/main/java/org/obm/push/dao/testsuite/WindowingToSnapshotDaoTest.java
Comment by Stephane COLSON [ 29/Apr/16 ]

OK, tested with Fairphone 2 (Android 5), SGS6 (Android 6) and iphone 5 (iOS 9) following instructions from Thomas HILAIRE comment.

Everything OK, except when upgrading opush starting from version 3.1.1 (with the issue), not all emails are retrieved with iPhone 5. But if I uncheck email sync, then check it again, everything is back. Seems legit.

Comment by Jenkins Continuous Integration Server [ 11/May/16 ]

ABORTED: Integrated in opush-master #262
OP-231 Add device id to the AUTH loggger (thilaire: 4e260fe2b7348208dbf0b6c8e1cb9a524eaab5fb)

  • push-core/src/main/java/org/obm/push/ActiveSyncServlet.java
    OP-231 Do not miss changes when the device get back with the same SK (thilaire: 8eb9bc1dfafd54094eda45f0c302e66b6a8606c3)
  • push-mail/src/test/java/org/obm/push/mail/MailBackendTest.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/OpushCassandraModule.java
  • push-dao-mail/src/main/java/org/obm/push/store/SnapshotDao.java
  • push-mail/src/test/java/org/obm/push/mail/MailBackendImplTest.java
  • push-dao-mail/src/main/java/org/obm/push/store/WindowingToSnapshotDao.java
  • push-mail/src/main/java/org/obm/push/mail/MailBackendSyncData.java
  • push-server/src/main/java/org/obm/push/migration/MigrationModule.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/dao/WindowingToSnapshotDaoCassandraImpl.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/dao/SnapshotDaoCassandraImpl.java
  • push-core/src/test/java/org/obm/push/ActiveSyncServletTest.java
  • push-dao-cassandra/src/main/java/org/obm/push/cassandra/dao/CassandraStructure.java
  • push-dao-testsuite/src/main/java/org/obm/push/dao/testsuite/WindowingToSnapshotDaoTest.java
  • push-mail/src/main/java/org/obm/push/mail/MailBackendImpl.java
  • push-mail/src/test/java/org/obm/push/mail/MailboxBackendTest.java
  • push-server/src/main/resources/versions/6/windowing_to_snapshot.cql
  • integration-testing/opush/src/test/java/org/obm/opush/MailBackendGetChangedTest.java
  • push-mail/src/test/java/org/obm/push/mail/MailBackendSyncDataTest.java
  • push-dao-cassandra/src/test/java/org/obm/push/cassandra/dao/WindowingToSnapshotDaoCassandraImplTest.java
Comment by yangping55 [ 04/Jul/17 ]

2017.7.5yangping
http://www.louisvuittonoutletus.us.com
http://www.edhardy-outlet.name
http://www.ralphlaurenoutlet.us.org
http://www.fitflopssaleclearanceofficial.us.com
http://www.nikefreerun.name
http://www.air-jordans.us.com
http://www.yeezyboost-350.us.com
http://www.longchamphandbags.us
http://www.louis-vuitton-handbags.us.org
http://www.airmax-95.us
http://www.saclongchamppas-cher.fr
http://www.coachoutletonlineinc.us.com
http://www.pandoracharms.us.com
http://www.coachoutletstore-online.us.com
http://www.adidassuperstar.me.uk
http://www.hermes-handbags.us
http://www.coachoutlets.in.net
http://www.christianlouboutinshoes.us.org
http://www.christianlouboutinsale.us.org
http://www.hollisterclothingstore.us
http://www.2017nikeairmax.us
http://www.nikefreeflyknit.name
http://www.fredperrypoloshirts.us
http://www.mulberry-bags.me.uk
http://www.kate-spadehandbags.us
http://www.coachfactoryoutletsonlines.us.com
http://www.nike-store.us.com
http://www.houstontexansjerseys.us.com
http://www.fitflops.org.uk
http://www.mont-blanc.in.net
http://www.louisvuitton-outlet-online.us.com
http://www.toms.in.net
http://www.denverbroncosjerseys.us
http://www.ralphlaurenuk.me.uk
http://www.pradaoutlets.us
http://www.cheapraybans.com.co
http://www.dallas-cowboysjerseys.us
http://www.tomsshoesoutlet.in.net
http://www.cheapraybansunglassesofficial.us.com
http://www.nikeairmax-pascher.fr
http://www.red-bottoms.us.com
http://www.airmaxoutletsaleus.com
http://www.supra-shoes.us
http://www.pandora-outlet.us.com
http://www.adidas-nmd.me.uk
http://www.adidas-shoes.us.com
http://www.katespadehandbags.us.com
http://www.adidasoutlet.us.com
http://www.michaelkorsoutletofficial.us
http://www.longchamp-handbags.us
http://www.birkenstocks.us
http://www.adidasnmd.us.org
http://www.coach-factoryoutlet-online.us.com
http://www.adidasshoes.me.uk
http://www.dolceandgabbanaoutlet.com
http://www.rolex-replicawatches.com.co
http://www.nike-airmax90.me.uk
http://www.adidas-shoes.me.uk
http://www.yeezyboost.org.uk
http://www.yeezyboost350.me.uk
http://www.ralphlaurensaleclearance.me.uk
http://www.todsoutlet.name
http://www.hermesbag.us.com
http://www.birkenstockpascher.fr
http://www.wwwlouisvuittonoutlet.us.com
http://www.yeezyboost-350.co.uk
http://www.coachoutletcoachfactoryoutletonline.us.com
http://www.true-religionjeansoutlet.in.net
http://www.fredperry.us.com
http://www.fitflopssaleclearancewholesale.us.com
http://www.outletlouisvuitton.us.com
http://www.michaelkorsoutletclearance.in.net
http://www.airjordanretro.us
http://www.michaelkorsofficial.us
http://www.coachoutletstoreonlineclearances.in.net
http://www.poloralphlaurencanada.ca
http://www.redbottomshoes.in.net
http://www.todsoutlet.us
http://www.nikeoutlet.us.com
http://www.coachfactory-outletstore.us.com
http://www.chiflatiron.in.net
http://www.ralphlaurensaleclearance.org.uk
http://www.pandora-bracelet.us
http://www.airmax90.org
http://www.officialmichaelkors.us.com
http://www.birkenstockshoes.us.com
http://www.timberlandbootsoutlet.us
http://www.cheapjordan-shoes.in.net
http://www.celineoutlet.us
http://www.coachfactory-outletonlines.us.com
http://www.airjordan-uk.org.uk
http://www.jameshardenshoes.us.com
http://www.seattleseahawksjerseys.us
http://www.adadassuperstar.com
http://www.newenglandpatriots-jerseys.us
http://www.coachoutlets.us.org
http://www.officialcoachoutlet.us.com
http://www.longchampoutletstore.com
http://www.storenike.fr
http://www.oakley.nom.co
http://www.pandora-bijoux.fr
http://www.nikeoutletonline.us.com
http://www.nikeshoes.us.com
http://www.nfljerseyscheap.in.net
http://www.onlinecoachfactoryoutlet.us.com
http://www.ralphlaurensaleclearance.co.uk
http://www.levisjeans.name
http://www.coach-outlets.us.com
http://www.adidaspascher.fr
http://www.christian-louboutin.us.com
http://www.yeezy-boost350v2.us.com
http://www.michael-korsoutlet.ca
http://www.versaceshoes.in.net
http://www.edhardyukclothing.me.uk
http://www.adidasshoes.name
http://www.coachfactoryoutlet-onlines.us.com
http://www.poloralphlauren-outlet.us.org
http://www.valentino.in.net
http://www.true-religionjeansoutlet.us.com
http://www.coachfactoryonlineoutlet.com.co
http://www.cheapmontblancpens.org
http://www.birkenstocksandals.name
http://www.oakleysunglassesonlinesale.us.com
http://www.michael-korshandbags.me.uk
http://www.coachoutletstoreinc.us.com
http://www.hermesbirkin.in.net
http://www.burberryoutlets.name
http://www.goldenstatewarriorsjerseys.us
http://www.coach-outletonline.us.org
http://www.officialcoachfactoryoutlet.eu.com
http://www.kate-spadeoutlets.us.com
http://www.coachoutletcanada.ca
http://www.clarks-shoes.us
http://www.coach-outletonlines.us.com
http://www.adidasyeezyboost-350.us
http://www.cheapmlbjerseyswholesale.us.com
http://www.hermesoutletonline.us
http://www.polo-ralphlauren.us.com
http://www.katespadeoutletonline.us.com
http://www.350yeezyboost.us.com
http://www.nikeoutletshoes.us
http://www.ralphlauren.net.co
http://www.pandorajewelryoutlet.in.net
http://www.pandora-uk.me.uk
http://www.outletmichaelkors.us.com
http://www.adidas-nmd.us.com
http://www.raybans.org.uk
http://www.marcjacobshandbag.us.com
http://www.michaelkorsoutletvip.in.net
http://www.yeezy-boost350v2.us
http://www.cheapmlbjerseys.us
http://www.cheaprolexreplicawatches.us
http://www.michaelkorshandbagsuk.org.uk
http://www.poloralph-lauren.in.net
http://www.true-religion.us.com
http://www.michaelkorsoutlet.co.uk
http://www.fitflopssalesclearance.us.com
http://www.birkenstocksandals.org.uk
http://www.mbtshoes.org.uk
http://www.pandora-jewelry.org.uk
http://www.mulberryoutlet.org.uk
http://www.raybansunglasses.net.co
http://www.discountoakleysunglassessale.us.com
http://www.cheap-jordans.us
http://www.michaelkorshandbags-outlet.us.org
http://www.pandoracharmssaleclearance.com
http://www.coachfactoryoutletstore.in.net
http://www.giuseppezanottioutlet.us
http://www.dansko-outlet.us
http://www.oakleysunglassessonlines.com
http://www.oakleyvaultsunglassesoutlet.us.com
http://www.nikestoreuk.me.uk
http://www.poloralph-lauren.fr
http://www.cheapoakleysunglassesofficial.us.com
http://www.adidas-outlet.us.com
http://www.cheapjordans.us.com
http://www.rolexreplica-watches.us.com
http://www.michaelkorshandbagsuk.co.uk
http://www.danskoshoes.us.com
http://www.pandoracharms.com.co
http://www.adidastrainersuk.org.uk
http://www.mbtshoes.in.net
http://www.birkenstockoutletstore.us.com
http://www.michaelkors-outlet.co.uk
http://www.burberry-outlet-canada.ca
http://www.stephcurry-shoes.us
http://www.adidasnmd-shoes.us
http://www.pandoracharmssaleclearance.me.uk
http://www.ralph-laurenoutlet.me.uk
http://www.coachoutletsstore.us.com
http://www.louboutin-paschers.fr
http://www.ultraboost.us
http://www.monclerjackets-uk.co.uk
http://www.oakley--sunglasses.us.org
http://www.longchampbags.uk
http://www.toryburchoutletonline.com.co
http://www.longchampbagsuk.me.uk
http://www.yeezyboost.us.com
http://www.cheapjordans.com.co
http://www.adidas-superstar.fr
http://www.coachoutletonlinecoachfactoryoutlet.us.com
http://www.kate-spadeoutlet.us.com
http://www.katespadehandbags.org.uk
http://www.vansshoes.in.net
http://www.sac-longchamp-pliage.fr
http://www.adidasnmd.org.uk
http://www.ralph-laurenuk.co.uk
http://www.cheapjordans-shoes.us.com
http://www.christianlouboutinoutlet.us
http://www.pandorajewelryoutlet.name
http://www.swarovski-crystal.uk
http://www.coachoutletstoreonline.com.co
http://www.michaelkors-outlet.ca
http://www.mlbjerseys-cheap.us.com
http://www.nike-airmax90.me.uk
http://www.ralph-laurenuk.org.uk
http://www.cheaprayban-sunglasses.com.co
http://www.salomonshoesoutlet.us
http://www.coachoutlet.in.net
http://www.michaelkorsoutletonlineclearance.in.net
http://www.clarksshoes.us.com
http://www.louboutin-shoes.us.com
http://www.cheapjordanshoes.us.com
http://www.catshoes.us.com
http://www.miamiheatjerseys.us
http://www.kevindurantshoes.us
http://www.monclerjacketsuk.org.uk
http://www.cheapoakleysunglassesonsale.us.com
http://www.ralphlaurenoutletonlines.us.com
http://www.adidas-superstar.us.com
http://www.longchamphandbags.me.uk
http://www.louboutin.org.uk
http://www.cheapnfl-jerseyswholesale.us.com
http://www.michaelkors-bags.me.uk
http://www.nikeair-max.org.uk
http://www.cheapjerseys.eu.com
http://www.toryburchoutlets.us
http://www.fendihandbags.us
http://www.parker-pens.us.com
http://www.discountnikeshoessc.org
http://www.nikeroshe.us
http://www.ralph-lauren-pas-cher.fr
http://www.polooutletstoreonline.us.com
http://www.michaelkors-handbags.us.org
http://www.gucci--borse.it
http://www.airmax90nike.us
http://www.mulberryhandbags.me.uk
http://www.fake-rolex.us
http://www.salomon-shoes.name
http://www.fitflopssandals.us.com
http://www.outletnike.us
http://www.moncleroutletjackets.us
http://www.outletlongchamp.us
http://www.coachhandbagsoutlet.us.com
http://www.christianlouboutinshoesoutlets.us.com
http://www.adidasshoes.us
http://www.ysl-handbags.us
http://www.jimmychoo.in.net
http://www.coachoutletsonlines.us.com
http://www.clevelandcavaliersjerseys.us
http://www.columbiashoes.name
http://www.coach-outlet.in.net
http://www.pandorasoldes.fr
http://www.pandoracharmsuk.uk
http://www.guccioutlets.us.org
http://www.underarmourshoes.us
http://www.pandoracharms.name
http://www.moncler-outlet.us.com
http://www.montblanc-pens.net.co
http://www.tomsoutletstore.in.net
http://www.fit-flopssaleclearance.us.com
http://www.michael-korsoutlet.us.com
http://www.ralphlauren-outletonline.us.com
http://www.adidasyeezyshoes.us.com
http://www.michaelkorsoutlets.us.com
http://www.sac-michaelkors.fr
http://www.true-religionjeans.in.net
http://www.moncleroutlet.in.net
http://www.saclongchampsolde.fr
http://www.rayban-sunglassesdiscount.us.com
http://www.mbtshoes.name
http://www.swarovskicrystal.name
http://www.pandora.us.com
http://www.ecco-shoes.us
http://www.valentinoshoesoutlets.us.com
http://www.doudounemonclerpascher.fr
http://www.christianlouboutinshoes.in.net

Generated at Fri Oct 18 13:36:52 CEST 2019 using JIRA 6.1.1#6155-sha1:7188aeec9a6b57d61ea04c52f235f15f55c105e2.