[OP-56] T#10428 Opush 3.0 stores plain password in database Created: 13/Jun/14  Updated: 15/Jul/14  Resolved: 16/Jun/14

Status: Closed
Project: Opush
Component/s: None
Affects Version/s: 3.0.0
Fix Version/s: 3.0.1

Type: Bug Priority: Critical
Reporter: Simon ELBAZ Assignee: Thomas HILAIRE
Resolution: Fixed Votes: 0
Labels: None
Remaining Estimate: Not Specified
Time Spent: Not Specified
Original Estimate: Not Specified

Rank: 6243
Sprint: Lyon Kanban

 Description   

Opush stores full credentials in Cassandra tables 'synced_collection' and 'monitored_collection.

I must only store username.



 Comments   
Comment by Matthieu EXT_BAECHLER [ 16/Jun/14 ]

This code is triggered for almost any synchronization.
We should ensure that the live migration is really well behaving by :
1/ having opush 3.0 running on one server
2/ install opush 3.0.1-rc on another server
3/ check that 3.0.1 does not allow synchronization
4/ upgrade schema via 3.0.1 crash console
5/ check that opush 3.0.0 still works
6/ restart opush 3.0.1
7/ both servers should allow syncing

Comment by Stephane COLSON [ 15/Jul/14 ]

OK with version 3.0.0-rc3 and synced_collection (for 3.0.0) and synced_collection_v2 (for 3.0.1). But I cannot see any password in monitored_collection.

 user                 | device                                                                                                                                                                      | collection_id | analysed_sync_collection
----------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------+-------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 iphone@obm14.lyn.lng | {"databaseId":3,"devId":{"deviceId":"ApplDNRH7C5UDP0N"},"devType":"iPhone","hints":{"hint.multipleCalendars":"false","hint.loadAttendees":"true"},"protocolVersion":"V121"} |            19 |             {"changes":null,"collectionId":19,"collectionPath":"obm:\\\\iphone@obm14.lyn.lng\\contacts\\-1:users","commands":{},"dataType":"CONTACTS","deletesAsMoves":null,"options":{"bodyPreferences":[{"allOrNone":false,"truncationSize":32768,"type":"PlainText"}],"conflict":1,"deletesAsMoves":true,"filterType":"THREE_DAYS_BACK","mimeSupport":null,"mimeTruncation":null,"truncation":9},"status":"OK","syncKey":{"syncKey":"250ddb50-779e-49ae-955d-5a786e0edb93"},"windowSize":25}

instead of

 credentials                                                                                                                    | device                                                                                                                                                                      | collection_id | analysed_sync_collection
--------------------------------------------------------------------------------------------------------------------------------+-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------+---------------+------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
 {"password":"toto","user":{"displayName":"iphone","domain":"obm14.lyn.lng","email":"iphone@obm14.lyn.lng","login":"iphone"}} | {"databaseId":3,"devId":{"deviceId":"ApplDNRH7C5UDP0N"},"devType":"iPhone","hints":{"hint.multipleCalendars":"false","hint.loadAttendees":"true"},"protocolVersion":"V121"} |            19 |            {"changes":null,"collectionId":19,"collectionPath":"obm:\\\\iphone@obm14.lyn.lng\\contacts\\-1:users","commands":{},"dataType":"CONTACTS","deletesAsMoves":null,"options":{"bodyPreferences":[{"allOrNone":false,"truncationSize":32768,"type":"PlainText"}],"conflict":1,"deletesAsMoves":true,"filterType":"THREE_DAYS_BACK","mimeSupport":null,"mimeTruncation":null,"truncation":9},"status":"OK","syncKey":{"syncKey":"c46da2b2-e874-4dd8-9e86-ab9e33b3aa64"},"windowSize":25}
Generated at Sat Aug 24 00:04:32 CEST 2019 using JIRA 6.1.1#6155-sha1:7188aeec9a6b57d61ea04c52f235f15f55c105e2.