OBM
  1. OBM
  2. OBMFULL-6433

External attendees to recurring events see a wrong time

    Details

    • Story Points:
      4
    • Similar Issues:
      Show 9 results 
    • Rank:
      6910
    • Sprint:
      2016#01

      Description

      Pre-conditions

      1. Have everyone use Europe/Paris as their timezone, including desktop ones on Linux and Windows (for outlook).
      2. Have usera and userb two internal OBM users.
      3. Have outlook as an external user using Outlook.
      4. Have gmail as an external user using GMail.
      5. Have yahoo as an external user using Yahoo.

      Reproduction steps

      1. As usera with TB, create an recurring event with userb, outlook, yahoo and gmail as attendees.

      Current behavior

      1. outlook sees the event at the wrong time (different shifts reproduced, sometimes 1h more, sometimes 1h more, etc.). NOK
      2. outlook sees that the event changes time after DST. NOK
      3. gmail sees that the event changes time after DST, though it sees the correct scheduled time. NOK
      4. yahoo sees that the event changes time after DST, though it sees the correct scheduled time. NOK

      Expected behavior

      1. userb, outlook, gmail and yahoo see the correct scheduled time. OK
      2. userb, outlook, gmail and yahoo see the event at the same time all year long, no matter if DST is enabled or not. OK

        Activity

        Hide
        David Dolcimascolo added a comment -

        To QA:

        • Impacts obm-sync as follows:
          • Invitations to recurring events are now sent including the timezone information of the organizer, in the form of a VTIMEZONE object in the ICS file.
          • This is a major change, and there's a probability that this breaks ICS parsing/handling of some clients...
        • To test
          • Create various different recurring events, inviting both internal and external users, and check that everything works as expected according to the ticket description.
          • Focus points on recurring events over DST switchs, on external users in different timezones, etc.
        • I personnaly tested a lot with external accounts, but not that much with internal users. You might want to check that internal users can still accept events with Lightning's blue bar, or with their smartphones.

        Tested on CentOS 6.

        Show
        David Dolcimascolo added a comment - To QA: Impacts obm-sync as follows: Invitations to recurring events are now sent including the timezone information of the organizer, in the form of a VTIMEZONE object in the ICS file. This is a major change, and there's a probability that this breaks ICS parsing/handling of some clients... To test Create various different recurring events, inviting both internal and external users, and check that everything works as expected according to the ticket description. Focus points on recurring events over DST switchs, on external users in different timezones, etc. I personnaly tested a lot with external accounts, but not that much with internal users. You might want to check that internal users can still accept events with Lightning's blue bar, or with their smartphones. Tested on CentOS 6.
        Hide
        Jenkins Continuous Integration Server added a comment -

        SUCCESS: Integrated in poll-master #203
        OBMFULL-6433 Recurring events are now sent with TZID'd dates. (ddolcimascolo: 36a533bb0c26d46559eb28205c742c4db15fff3c)

        • java/sync/icalendar/src/test/resources/icsFile/eventsWithExceptionsDtStartWithTimeZone.ics
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/requestWithoutTimeZone.ics
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/cancelWithoutTimeZone.ics
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/replyWithTimeZone.ics
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/cancelWithTimeZone.ics
        • java/sync/icalendar/src/main/java/org/obm/icalendar/Ical4jHelper.java
        • java/sync/icalendar/pom.xml
        • java/sync/icalendar/src/test/java/org/obm/icalendar/Ical4jHelperTest.java
        • java/sync/services-module/src/test/java/org/obm/sync/server/mailer/EventChangeMailerTest.java
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/replyWithoutTimeZone.ics
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/requestWithTimeZone.ics
        Show
        Jenkins Continuous Integration Server added a comment - SUCCESS: Integrated in poll-master #203 OBMFULL-6433 Recurring events are now sent with TZID'd dates. (ddolcimascolo: 36a533bb0c26d46559eb28205c742c4db15fff3c ) java/sync/icalendar/src/test/resources/icsFile/eventsWithExceptionsDtStartWithTimeZone.ics java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /requestWithoutTimeZone.ics java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /cancelWithoutTimeZone.ics java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /replyWithTimeZone.ics java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /cancelWithTimeZone.ics java/sync/icalendar/src/main/java/org/obm/icalendar/Ical4jHelper.java java/sync/icalendar/pom.xml java/sync/icalendar/src/test/java/org/obm/icalendar/Ical4jHelperTest.java java/sync/services-module/src/test/java/org/obm/sync/server/mailer/EventChangeMailerTest.java java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /replyWithoutTimeZone.ics java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /requestWithTimeZone.ics
        Hide
        Jenkins Continuous Integration Server added a comment -

        SUCCESS: Integrated in poll-features-el7 #7
        OBMFULL-6433 Recurring events are now sent with TZID'd dates. (ddolcimascolo: 36a533bb0c26d46559eb28205c742c4db15fff3c)

        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/replyWithoutTimeZone.ics
        • java/sync/icalendar/pom.xml
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/cancelWithoutTimeZone.ics
        • java/sync/icalendar/src/main/java/org/obm/icalendar/Ical4jHelper.java
        • java/sync/icalendar/src/test/resources/icsFile/eventsWithExceptionsDtStartWithTimeZone.ics
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/replyWithTimeZone.ics
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/requestWithTimeZone.ics
        • java/sync/services-module/src/test/java/org/obm/sync/server/mailer/EventChangeMailerTest.java
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/cancelWithTimeZone.ics
        • java/sync/icalendar/src/test/java/org/obm/icalendar/Ical4jHelperTest.java
        • java/sync/icalendar/src/test/resources/icsFile/OBMFULL-6433/requestWithoutTimeZone.ics
        Show
        Jenkins Continuous Integration Server added a comment - SUCCESS: Integrated in poll-features-el7 #7 OBMFULL-6433 Recurring events are now sent with TZID'd dates. (ddolcimascolo: 36a533bb0c26d46559eb28205c742c4db15fff3c ) java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /replyWithoutTimeZone.ics java/sync/icalendar/pom.xml java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /cancelWithoutTimeZone.ics java/sync/icalendar/src/main/java/org/obm/icalendar/Ical4jHelper.java java/sync/icalendar/src/test/resources/icsFile/eventsWithExceptionsDtStartWithTimeZone.ics java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /replyWithTimeZone.ics java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /requestWithTimeZone.ics java/sync/services-module/src/test/java/org/obm/sync/server/mailer/EventChangeMailerTest.java java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /cancelWithTimeZone.ics java/sync/icalendar/src/test/java/org/obm/icalendar/Ical4jHelperTest.java java/sync/icalendar/src/test/resources/icsFile/ OBMFULL-6433 /requestWithoutTimeZone.ics
        Hide
        Stephane COLSON added a comment -

        OK, tested on the same timezone with:

        • TB38 creating events (daily, weekly, every 2 weeks, every weekday, monthly, yearly, with or without end) with internal attendees (with iphone 5 and Android 5, TB and ui) and external attendees (outlook.com, google calendar and OBM)

        I found OP-240 with Fairphone 2 (Android 5.1) and weekly events, also reproduced with another Android 5.0.2 (Alcatel iDol3)

        OK, also tested with 2 Timezone on the TB38 creating the event (Katmandu and Los Angeles). For example with Los Angeles at 07AM, all other users (internal or external) in Paris timezone will have the event:

        • at 4PM until Oct/29
        • at 3PM from Oct/30 (DST Paris) to Nov/05
        • at 4PM from Nov/06 (DST Los Angeles) to Mar/11
        • at 3PM from Mar/12 (DST Los Angeles) to Mar/25
        • at 4PM from Mar/26 (DST Paris) to...etc
        Show
        Stephane COLSON added a comment - OK, tested on the same timezone with: TB38 creating events (daily, weekly, every 2 weeks, every weekday, monthly, yearly, with or without end) with internal attendees (with iphone 5 and Android 5, TB and ui) and external attendees (outlook.com, google calendar and OBM) I found OP-240 with Fairphone 2 (Android 5.1) and weekly events, also reproduced with another Android 5.0.2 (Alcatel iDol3) OK, also tested with 2 Timezone on the TB38 creating the event (Katmandu and Los Angeles). For example with Los Angeles at 07AM, all other users (internal or external) in Paris timezone will have the event: at 4PM until Oct/29 at 3PM from Oct/30 (DST Paris) to Nov/05 at 4PM from Nov/06 (DST Los Angeles) to Mar/11 at 3PM from Mar/12 (DST Los Angeles) to Mar/25 at 4PM from Mar/26 (DST Paris) to...etc

          People

          • Assignee:
            David Dolcimascolo
            Reporter:
            David Dolcimascolo
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile