OBM
  1. OBM
  2. OBMFULL-6455

T#16375 Deactivated users (archived) are still present in TB 'users' addressbook

    Details

    • Story Points:
      5
    • Similar Issues:
      Show 10 results 
    • Rank:
      6966
    • Sprint:
      2016#01

      Description

      Reproduction steps

      1. As admin, disable usera on OBM ui
      2. As userb with TB obm-connector synchronised check the addressbook for usera

      Current behavior

      1. usera who's disable still appear in TB addressbookNOK

      Expected behavior

      1. Deactivate users like usera should not be visible on TB addressbooksOK

      Additional informations

      Reset OBM connector removed the archived users.

        Activity

        Hide
        David Dolcimascolo added a comment -

        I've analyzed this.
        We need to improve the obm-sync protocol for this to work, because right now when a contact is deleted the server only sends it's ID to the client. This does not work with users because IDs may overlap with contact ones.
        So we need to send the parent addressbook so that the client know where to delete the contact.

        -> This implies a change in the lightning connector, too.

        Show
        David Dolcimascolo added a comment - I've analyzed this. We need to improve the obm-sync protocol for this to work, because right now when a contact is deleted the server only sends it's ID to the client. This does not work with users because IDs may overlap with contact ones. So we need to send the parent addressbook so that the client know where to delete the contact. -> This implies a change in the lightning connector, too.
        Hide
        David Dolcimascolo added a comment -

        To QA:

        • This impacts obm-sync and the lightning-connector.
          • We should also update the Outlook connector but not now. I've created OUTLOOKCON-99 to follow this.
          • obm-sync can no return the parent addressbook of a deleted contact, or user. An archived user is sent by obm-sync as a deletion.
          • The lightning-connector can now understand this and remove users from the "OBM - Users" address book
        • To test, follow the steps to reproduce.
          • Can be interesting to test that contact deletion still work as expected
          • You should also check the multiple combinations of connector + OBM (old/old, old/new, etc.)

        Tested on CentOS7 with TB38.

        Show
        David Dolcimascolo added a comment - To QA: This impacts obm-sync and the lightning-connector . We should also update the Outlook connector but not now. I've created OUTLOOKCON-99 to follow this. obm-sync can no return the parent addressbook of a deleted contact, or user. An archived user is sent by obm-sync as a deletion. The lightning-connector can now understand this and remove users from the "OBM - Users" address book To test, follow the steps to reproduce. Can be interesting to test that contact deletion still work as expected You should also check the multiple combinations of connector + OBM (old/old, old/new, etc.) Tested on CentOS7 with TB38.
        Hide
        Jenkins Continuous Integration Server added a comment -

        SUCCESS: Integrated in connector-poll-master #164
        OBMFULL-6455 Now supporting user deletion/archiving. (ddolcimascolo: rev e42fa64413fd8fae03a2121275944543ad112fea)

        • src/components/obm-sync-rest/obmRAddressBookProxy.js
        • src/components/obm-sync-rest/obmRAddressBookSync.js
        • idl/obmIRAddressBookProxy.idl
          OBMFULL-6455 Compiled XPT module. (ddolcimascolo: rev 5990de651e795847200d352eb2588fff0f15474e)
        • src/components/obm.xpt
        Show
        Jenkins Continuous Integration Server added a comment - SUCCESS: Integrated in connector-poll-master #164 OBMFULL-6455 Now supporting user deletion/archiving. (ddolcimascolo: rev e42fa64413fd8fae03a2121275944543ad112fea) src/components/obm-sync-rest/obmRAddressBookProxy.js src/components/obm-sync-rest/obmRAddressBookSync.js idl/obmIRAddressBookProxy.idl OBMFULL-6455 Compiled XPT module. (ddolcimascolo: rev 5990de651e795847200d352eb2588fff0f15474e) src/components/obm.xpt
        Hide
        Jenkins Continuous Integration Server added a comment -

        SUCCESS: Integrated in poll-master #228
        OBMFULL-6455 obm-sync now returns the bookId for removed contacts. (ddolcimascolo: 2e449f96d6f291efc0e37a9b0cbe8405fd29b5b7)

        • java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/ContactUpdates.java
        • java/sync/integration-testing/services/src/test/resources/sql/org/obm/sync/calendar/h2.sql
        • java/sync/integration-testing/services/src/test/resources/sql/org/obm/sync/contact/archivedOrDeletedUsers.sql
        • java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/ContactDao.java
        • java/sync/obm-domain-objects/src/main/java/org/obm/sync/book/BookItemsParser.java
        • java/sync/obm-domain-objects/src/main/java/org/obm/sync/items/ContactChanges.java
        • java/sync/integration-testing/services/src/test/java/org/obm/sync/contact/ContactClientIntegrationTest.java
        • java/sync/obm-domain-objects/src/test/resources/SimpleContactChanges.xml
        • java/sync/obm-domain-objects/src/main/java/org/obm/sync/book/DeletedContact.java
        • java/sync/obm-domain-objects/src/main/java/org/obm/sync/book/BookItemsWriter.java
        • java/sync/obm-domain-objects/src/main/java/org/obm/sync/items/AddressBookChangesResponse.java
        • java/sync/obm-domain-objects/src/test/java/org/obm/sync/BeansTest.java
        • java/sync/services-module/src/test/java/fr/aliacom/obm/common/contact/AddressBookBindingImplTest.java
        • java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/UserDao.java
        • java/sync/obm-domain-objects/src/test/java/org/obm/sync/book/BookItemsWriterTest.java
        • java/sync/obm-domain-objects/src/main/java/org/obm/sync/book/Contact.java
        • java/sync/obm-domain-objects/src/test/resources/SimpleAddressBookChanges.xml
        • java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/ContactDaoJdbcImpl.java
        • java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/AddressBookBindingImpl.java
        • java/sync/integration-testing/services/src/test/resources/sql/org/obm/sync/contact/ContactClientIntegrationTestAdditionalDBScripts
          OBMFULL-6455 Added new ServerCapability. (ddolcimascolo: a141add64155e57d3b26015eb240db3213dc6be4)
        • java/sync/services-module/src/test/resources/org/obm/sync/server/tokenWithAllCapabilities.xml
        • java/sync/services-module/src/test/java/org/obm/sync/server/handler/SimpleLoginHandlerTest.java
        • java/sync/obm-domain-objects/src/main/java/org/obm/sync/ServerCapability.java
        Show
        Jenkins Continuous Integration Server added a comment - SUCCESS: Integrated in poll-master #228 OBMFULL-6455 obm-sync now returns the bookId for removed contacts. (ddolcimascolo: 2e449f96d6f291efc0e37a9b0cbe8405fd29b5b7 ) java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/ContactUpdates.java java/sync/integration-testing/services/src/test/resources/sql/org/obm/sync/calendar/h2.sql java/sync/integration-testing/services/src/test/resources/sql/org/obm/sync/contact/archivedOrDeletedUsers.sql java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/ContactDao.java java/sync/obm-domain-objects/src/main/java/org/obm/sync/book/BookItemsParser.java java/sync/obm-domain-objects/src/main/java/org/obm/sync/items/ContactChanges.java java/sync/integration-testing/services/src/test/java/org/obm/sync/contact/ContactClientIntegrationTest.java java/sync/obm-domain-objects/src/test/resources/SimpleContactChanges.xml java/sync/obm-domain-objects/src/main/java/org/obm/sync/book/DeletedContact.java java/sync/obm-domain-objects/src/main/java/org/obm/sync/book/BookItemsWriter.java java/sync/obm-domain-objects/src/main/java/org/obm/sync/items/AddressBookChangesResponse.java java/sync/obm-domain-objects/src/test/java/org/obm/sync/BeansTest.java java/sync/services-module/src/test/java/fr/aliacom/obm/common/contact/AddressBookBindingImplTest.java java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/UserDao.java java/sync/obm-domain-objects/src/test/java/org/obm/sync/book/BookItemsWriterTest.java java/sync/obm-domain-objects/src/main/java/org/obm/sync/book/Contact.java java/sync/obm-domain-objects/src/test/resources/SimpleAddressBookChanges.xml java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/ContactDaoJdbcImpl.java java/sync/services-module/src/main/java/fr/aliacom/obm/common/contact/AddressBookBindingImpl.java java/sync/integration-testing/services/src/test/resources/sql/org/obm/sync/contact/ContactClientIntegrationTestAdditionalDBScripts OBMFULL-6455 Added new ServerCapability. (ddolcimascolo: a141add64155e57d3b26015eb240db3213dc6be4 ) java/sync/services-module/src/test/resources/org/obm/sync/server/tokenWithAllCapabilities.xml java/sync/services-module/src/test/java/org/obm/sync/server/handler/SimpleLoginHandlerTest.java java/sync/obm-domain-objects/src/main/java/org/obm/sync/ServerCapability.java
        Hide
        Stephane COLSON added a comment -

        OK, tested with

        • TB38 + connector 4.1.2 + obm 3.1.6 => Bug reproduced
        • TB38 + obm-connector-4.1.2+git2016-04-13_164_5990de6 + obm 3.1.6 => Bug reproduced, user not deleted in TB synchronized if deactivated + if you delete a contact, then a user not deactivated is randomly removed from the list of users
        • TB31 + obm-connector-4.1.2+git2016-04-13_164_5990de6 + obm 3.1.6 => Bug reproduced; user not deleted unles you reset connector
        • TB38 + connecteur 4.1.2 + obm 3.2.0~0.alpha0+git20160419-1747-3fc3c43 => Bug reproduced, user not deleted in TB synchronized if deactivated + if you delete a contact, then a user not deactivated is randomly removed from the list of users
        • TB31 + connecteur 4.1.2 + obm 3.2.0~0.alpha0+git20160419-1747-3fc3c43 => Bug reproduced, user not deleted in TB synchronized if deactivated + if you delete a contact, then a user not deactivated is randomly removed from the list of users
        • TB38 + obm-connector-4.1.2+git2016-04-13_164_5990de6 + obm 3.2.0~0.alpha0+git20160419-1747-3fc3c43 OK
        • TB31 + obm-connector-4.1.2+git2016-04-13_164_5990de6 + obm 3.2.0~0.alpha0+git20160419-1747-3fc3c43 OK
        Show
        Stephane COLSON added a comment - OK, tested with TB38 + connector 4.1.2 + obm 3.1.6 => Bug reproduced TB38 + obm-connector-4.1.2+git2016-04-13_164_5990de6 + obm 3.1.6 => Bug reproduced, user not deleted in TB synchronized if deactivated + if you delete a contact, then a user not deactivated is randomly removed from the list of users TB31 + obm-connector-4.1.2+git2016-04-13_164_5990de6 + obm 3.1.6 => Bug reproduced; user not deleted unles you reset connector TB38 + connecteur 4.1.2 + obm 3.2.0~0.alpha0+git20160419-1747-3fc3c43 => Bug reproduced, user not deleted in TB synchronized if deactivated + if you delete a contact, then a user not deactivated is randomly removed from the list of users TB31 + connecteur 4.1.2 + obm 3.2.0~0.alpha0+git20160419-1747-3fc3c43 => Bug reproduced, user not deleted in TB synchronized if deactivated + if you delete a contact, then a user not deactivated is randomly removed from the list of users TB38 + obm-connector-4.1.2+git2016-04-13_164_5990de6 + obm 3.2.0~0.alpha0+git20160419-1747-3fc3c43 OK TB31 + obm-connector-4.1.2+git2016-04-13_164_5990de6 + obm 3.2.0~0.alpha0+git20160419-1747-3fc3c43 OK
        Hide
        Jenkins Continuous Integration Server added a comment -

        SUCCESS: Integrated in connector-release #106
        OBMFULL-6455 Now supporting user deletion/archiving. (ddolcimascolo: rev e42fa64413fd8fae03a2121275944543ad112fea)

        • src/components/obm-sync-rest/obmRAddressBookSync.js
        • src/components/obm-sync-rest/obmRAddressBookProxy.js
        • idl/obmIRAddressBookProxy.idl
          OBMFULL-6455 Compiled XPT module. (ddolcimascolo: rev 5990de651e795847200d352eb2588fff0f15474e)
        • src/components/obm.xpt
        Show
        Jenkins Continuous Integration Server added a comment - SUCCESS: Integrated in connector-release #106 OBMFULL-6455 Now supporting user deletion/archiving. (ddolcimascolo: rev e42fa64413fd8fae03a2121275944543ad112fea) src/components/obm-sync-rest/obmRAddressBookSync.js src/components/obm-sync-rest/obmRAddressBookProxy.js idl/obmIRAddressBookProxy.idl OBMFULL-6455 Compiled XPT module. (ddolcimascolo: rev 5990de651e795847200d352eb2588fff0f15474e) src/components/obm.xpt

          People

          • Assignee:
            David Dolcimascolo
            Reporter:
            Julien ALTMEYER
          • Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Agile